Skip to content

remove old reference to onClick, this is now handled via ButterKnife#993

Merged
mario merged 3 commits into
masterfrom
contactButton
May 13, 2017
Merged

remove old reference to onClick, this is now handled via ButterKnife#993
mario merged 3 commits into
masterfrom
contactButton

Conversation

@tobiasKaminsky

Copy link
Copy Markdown
Member

use "end" instead of "right" for RTL support

@AndyScherzinger

AndyScherzinger commented May 13, 2017

Copy link
Copy Markdown
Member

👍 Looking good :)

Approved with PullApprove

@mario

mario commented May 13, 2017

Copy link
Copy Markdown
Contributor

Looks good, but build fails?

@AndyScherzinger

AndyScherzinger commented May 13, 2017

Copy link
Copy Markdown
Member

👍 rebased and rerun, @mario please re-approve and merge

Approved with PullApprove

@mario

mario commented May 13, 2017

Copy link
Copy Markdown
Contributor

👍

Approved with PullApprove

@mario
mario merged commit 01fc8ab into master May 13, 2017
@mario
mario deleted the contactButton branch May 13, 2017 20:58
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 1.5.0 milestone May 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants